London | 26-ITP-January | Karla Grajales | Sprint 2 | Coursework/sprint 2#925
London | 26-ITP-January | Karla Grajales | Sprint 2 | Coursework/sprint 2#925Grajales-K wants to merge 20 commits intoCodeYourFuture:mainfrom
Conversation
…p ignoring parameters with hardcoded values
…e and remove the spaces and replace with underScores. I implement toUpperCase() and replace()
…umber and set the display result as Money
…e, one is to separate hours, minutes and seconds and the pad() is formatting the time displayed
Grajales-K
added
🏕 Priority Mandatory
LonMcGregor
added
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Well done on this task so far, you have given good explanations to the debugging tasks.
I have left a couple of comments where you could improve further.
For learning, I would suggest understanding the basics before starting on using built-in functions. Something that might be interesting is seeing if you can write your own forEach or map function, and once you've got that down, then just using the built in functions.
LonMcGregor
added
Reviewed
…ts and midnight and midday handling test: add asserts for morning, afternoon, and midnight cases
const { t } = require("tar");
because is not doing nothing with the math function
Thank you very much, @LonMcGregor, for your review and your suggestions. I really appreciate your time, and yes, I want to learn and am happy to read your suggestion. I'm actually trying to use for loops in Codewars right now to learn how the data really moves. Built-in methods are easy, but I want to understand what's happening 'under the hood' before I use them all the time. |
Grajales-K
added
the
Needs Review
Grajales-K
added
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Great work!
I'm honestly not sure what the require tar, but good to remove it if not needed.
You don't always need to make things a one-liner, but I mention it as a way to get some practice. Typically i find if the function is very short it can make things more readable.
This task is done now.
LonMcGregor
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
In this project, I implemented and refactored functions to handle data conversion (Time and Currency). I also documented the execution flow of nested functions and how parameters are processed when functions are invoked sequentially.
Questions
What is the most effective learning path for mastering functions: should I focus on core logic like loops first, or move directly to built-in array methods (like .forEach or .map)?